Skip to content

[config] validate gateway mode - #277

Open
capcom6 wants to merge 2 commits into
masterfrom
config/validate-gateway-mode
Open

capcom6 wants to merge 2 commits into
masterfrom
config/validate-gateway-mode

Conversation

@capcom6

@capcom6 capcom6 commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

RetriggerConfidence Score: 5/5

The current PR appears safe to merge because unsupported and explicitly empty gateway modes now fail server startup instead of producing inconsistent behavior.

Summary

The PR validates gateway mode while constructing push configuration, returning a recognizable configuration error unless the mode is public or private.

  • Maps public mode to FCM and private mode to upstream push explicitly.
  • Adds ErrInvalidConfig for configuration error classification.
  • Documents the validation behavior in a new changelog.
  • Updates the environment example with existing message-hashing and OTP settings.

Reviews (5) · Last reviewed commit: "[docs] cleanup readme"

Comment thread internal/config/module.go Outdated
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🤖 Pull request artifacts

Platform File
🐳 Docker GitHub Container Registry
🍎 Darwin arm64 server_Darwin_arm64.tar.gz
🍎 Darwin x86_64 server_Darwin_x86_64.tar.gz
🐧 Linux arm64 server_Linux_arm64.tar.gz
🐧 Linux i386 server_Linux_i386.tar.gz
🐧 Linux x86_64 server_Linux_x86_64.tar.gz
🪟 Windows arm64 server_Windows_arm64.zip
🪟 Windows i386 server_Windows_i386.zip
🪟 Windows x86_64 server_Windows_x86_64.zip

@capcom6
capcom6 force-pushed the config/validate-gateway-mode branch from 7eb2f00 to 2fbc877 Compare September 23, 2026 04:24
@capcom6
capcom6 force-pushed the config/validate-gateway-mode branch from 2fbc877 to 26e52ef Compare September 25, 2026 01:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant