Conversation
🤖 Pull request artifacts
|
capcom6
force-pushed
the
config/validate-gateway-mode
branch
from
September 23, 2026 04:24
7eb2f00 to
2fbc877
Compare
capcom6
force-pushed
the
config/validate-gateway-mode
branch
from
September 25, 2026 01:57
2fbc877 to
26e52ef
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current PR appears safe to merge because unsupported and explicitly empty gateway modes now fail server startup instead of producing inconsistent behavior.
Summary
The PR validates gateway mode while constructing push configuration, returning a recognizable configuration error unless the mode is
publicorprivate.ErrInvalidConfigfor configuration error classification.Reviews (5) · Last reviewed commit: "[docs] cleanup readme"